Skip to content

Conversation

@wk9874
Copy link
Collaborator

@wk9874 wk9874 commented Oct 13, 2025

Add 'throw_exceptions' option to Sender

Python Version(s) Tested: 3.10

Operating System(s): Ubuntu

📝 Summary

Some of the offline mode tests were failing due to error.args[0] not working with ValidationErrors, changes this to str(error) instead

Also this gave misleading error messages in the tests- would prefer offline mode tests to throw errors encountered by sender (and more widely, users should also have this choice). So adds throw_exception option to Sender which will throw exceptions when encountered instead of suppressing and logging (which is default behaviour). Changed all tests to use this

🔍 Diagnosis

Failing gridmetrics test

✔️ Checklist

  • Unit and integration tests passing.
  • Pre-commit hooks passing.
  • Quality checks passing.

@kzscisoft kzscisoft merged commit 806ba68 into kzscisoft/use-utc Oct 13, 2025
1 check passed
@kzscisoft kzscisoft deleted the wk9874/sender_exception_handling_fixz branch October 13, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants